Closed
Bug 1031395
Opened 11 years ago
Closed 11 years ago
Clang Static Analysis: Remove never read value to fix a minor warning found by scan-build.
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: pmaddi, Assigned: pmaddi)
References
(Blocks 1 open bug)
Details
(Keywords: clang-analyzer)
Attachments
(1 file)
|
1.14 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
The attached patch fixes a warning detected by scan-build, the clang static analyzer.
|
Assignee | |
Updated•11 years ago
|
Attachment #8447271 -
Flags: review?(ehsan)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8447271 [details] [diff] [review]
0001-Remove-a-double-assignment-to-limit-to-fix-a-minor-w.patch
Review of attachment 8447271 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks a lot for your patch, Pranav!
Attachment #8447271 -
Flags: review?(ehsan) → review+
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 2•11 years ago
|
||
Just for the record: a bit of hg blame / bonsai blame archeology shows that this dates back to the very first version of this code, added in bug 70394, back in 2001.
(It's in attachment 26583 [details], the third attachment on that bug; this same code is at the beginning of nsBidi::GetRuns() in that file.)
Blocks: 70394
Version: unspecified → Trunk
|
|
Assignee | |
Comment 3•11 years ago
|
||
Daniel, that's pretty neat :)
|
||
Comment 4•11 years ago
|
||
Assignee: nobody → pranav.maddi
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
||
Updated•10 years ago
|
Keywords: clang-analyzer
You need to log in
before you can comment on or make changes to this bug.
Description
•